Skip to content

Feature: Display item size in tooltip #11069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 27, 2023
Merged

Feature: Display item size in tooltip #11069

merged 4 commits into from
Jan 27, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jan 25, 2023 •
edited
Loading

Changes

  • Added item size to the tooltip
  • Display correct tooltip in the column layout

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

QuaintMako
QuaintMako reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this process be costy? Is the size calculated on the fly? I cannot check right now, but if so, would be good to check for optimisations.

QuaintMako
QuaintMako reviewed Jan 27, 2023
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion of fix.
Otherwise, LGTM and works on my computer.

@yaira2 @QuaintMako
Update src/Files.App/Filesystem/ListedItem.cs
ec554ed 
Co-authored-by: Quaint Mako <110472580+QuaintMako@users.noreply.github.com>
@yaira2 yaira2 requested a review from QuaintMako January 27, 2023 14:43
QuaintMako
QuaintMako previously approved these changes Jan 27, 2023
View reviewed changes
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 27, 2023
ferrariofilippo
ferrariofilippo approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works

@yaira2 yaira2 merged commit e9df282 into main Jan 27, 2023
@yaira2 yaira2 deleted the ya/ItemSize branch February 3, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrariofilippo ferrariofilippo ferrariofilippo approved these changes

@QuaintMako QuaintMako QuaintMako left review comments

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaira2 @ferrariofilippo @QuaintMako