Skip to content

Feature: Added support for installing multiple fonts at the same time #11029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 18, 2023
Merged

Feature: Added support for installing multiple fonts at the same time #11029

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0cfad43
Add support for installing multiple fonts at a time
hecksmosis Jan 16, 2023
e8399aa
Introduce method
hecksmosis Jan 16, 2023
40e88dc
Merge branch 'main' into multiple_fonts_installation
hecksmosis Jan 16, 2023
5001e88
Update ShellContextMenuHelper.cs
hecksmosis Jan 16, 2023
bee7db4
Apply suggestion
hecksmosis Jan 18, 2023
194eaaa
Merge branch 'main' into multiple_fonts_installation
hecksmosis Jan 18, 2023
f8086f2
Update src/Files.App/Helpers/ShellContextMenuHelper.cs
yaira2 Jan 18, 2023
c8db29e
Update src/Files.App/Helpers/ShellContextMenuHelper.cs
yaira2 Jan 18, 2023
42cf4dc
Apply suggestion
hecksmosis Jan 18, 2023
c8e87f1
Apply suggestion
hecksmosis Jan 18, 2023
77f8d2f
Apply suggestion
hecksmosis Jan 18, 2023
c5bf43b
Merge branch 'main' into multiple_fonts_installation
hecksmosis Jan 18, 2023
3429f9b
Add registry key variable
hecksmosis Jan 18, 2023
d0776fc
Merge branch 'multiple_fonts_installation' of https://github.com/heck…
hecksmosis Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/Files.App/Helpers/ShellContextMenuHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,16 +172,15 @@ async void InvokeShellMenuItem(ContextMenu contextMenu, object? tag)
{
case "install" when isFont:
{
var userFontDir = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData), "Microsoft", "Windows", "Fonts");
var destName = Path.Combine(userFontDir, Path.GetFileName(contextMenu.ItemsPath[0]));
Win32API.RunPowershellCommand($"-command \"Copy-Item '{contextMenu.ItemsPath[0]}' '{userFontDir}'; New-ItemProperty -Name '{Path.GetFileNameWithoutExtension(contextMenu.ItemsPath[0])}' -Path 'HKCU:\\Software\\Microsoft\\Windows NT\\CurrentVersion\\Fonts' -PropertyType string -Value '{destName}'\"", false);
foreach (string path in contextMenu.ItemsPath)
InstallFont(path, false);
}
break;

case "installAllUsers" when isFont:
{
var winFontDir = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.Windows), "Fonts");
Win32API.RunPowershellCommand($"-command \"Copy-Item '{contextMenu.ItemsPath[0]}' '{winFontDir}'; New-ItemProperty -Name '{Path.GetFileNameWithoutExtension(contextMenu.ItemsPath[0])}' -Path 'HKLM:\\Software\\Microsoft\\Windows NT\\CurrentVersion\\Fonts' -PropertyType string -Value '{Path.GetFileName(contextMenu.ItemsPath[0])}'\"", true);
foreach (string path in contextMenu.ItemsPath)
InstallFont(path, true);
}
break;

Expand All @@ -199,7 +198,17 @@ async void InvokeShellMenuItem(ContextMenu contextMenu, object? tag)
await contextMenu.InvokeItem(menuId);
break;
}

void InstallFont(string path, bool asAdmin)
{
string dir = asAdmin ? Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.Windows), "Fonts")
: Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData), "Microsoft", "Windows", "Fonts");

string registryKey = asAdmin ? "HKLM:\\Software\\Microsoft\\Windows NT\\CurrentVersion\\Fonts"
: "HKCU:\\Software\\Microsoft\\Windows NT\\CurrentVersion\\Fonts";

Win32API.RunPowershellCommand($"-command \"Copy-Item '{path}' '{dir}'; New-ItemProperty -Name '{Path.GetFileNameWithoutExtension(path)}' -Path '{registryKey}' -PropertyType string -Value '{dir}'\"", asAdmin);
}
//contextMenu.Dispose(); // Prevents some menu items from working (TBC)
}
}
Expand All @@ -211,4 +220,4 @@ public static List<ContextMenuFlyoutItemViewModel> GetOpenWithItems(List<Context
return item?.Items;
}
}
}
}