Fix: Prevent creating folders with forbidden names #10967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
changed the title
yaira2
reviewed
Jan 9, 2023
src/Files.App/Filesystem/FilesystemOperations/FilesystemOperations.cs
Outdated
Show resolved
Hide resolved
yaira2
reviewed
Jan 9, 2023
src/Files.App/Filesystem/FilesystemOperations/Helpers/FilesystemHelpers.cs
Show resolved
Hide resolved
|
Why are not just checking for invalid names in the create file dialog? |
Need to cover rename to as well. |
|
Rename already has the check |
|
If we cover this in the dialog we would have to check in multiple places, wouldn't we? |
What dialog is displayed there? We should reuse as much code as possible. |
|
I've noticed there isn't actually a check for rename. (I've added one) |
yaira2
reviewed
Jan 19, 2023
src/Files.App/Filesystem/FilesystemOperations/Helpers/FilesystemHelpers.cs
Show resolved
Hide resolved
yaira2
changed the title
yaira2
reviewed
Jan 19, 2023
Co-authored-by: yaira2 <39923744+yaira2@users.noreply.github.com>
QuaintMako
reviewed
Jan 20, 2023
src/Files.App/Filesystem/FilesystemOperations/Helpers/FilesystemHelpers.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Filesystem/FilesystemOperations/Helpers/FilesystemHelpers.cs
Show resolved
Hide resolved
…fix_forbidden_filenames
…is/Files into fix_forbidden_filenames
QuaintMako
previously approved these changes
Jan 20, 2023
1 task
QuaintMako
approved these changes
Jan 22, 2023
yaira2
added
ready to merge
|
@hecksmosis thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Items resolved / related issues by this PR.
Validation
How did you test these changes?