Skip to content

Feature: Added progress bar to properties to indicate when the size is being calculated #10915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 5, 2023
Merged

Feature: Added progress bar to properties to indicate when the size is being calculated #10915

merged 7 commits into from
Jan 5, 2023

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Jan 3, 2023 •
edited by yaira2
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
1

@hecksmosis
Copy link
Contributor

The spacing seems to be off, can you fix it? (Very slight issue)
image

@ferrariofilippo
Copy link
Contributor Author

ferrariofilippo commented Jan 3, 2023 •
edited
Loading

The spacing seems to be off, can you fix it? (Very slight issue)

You mean vertically? Or do you mean it's not centered horizontally?

@yaira2
Copy link
Member

yaira2 commented Jan 3, 2023

Can you try to revert to the progress bar and see how it looks?

@ferrariofilippo
Copy link
Contributor Author

Can you try to revert to the progress bar and see how it looks?

Here it is:

1.mp4

@ferrariofilippo
Copy link
Contributor Author

I think the ProgressBar looks better... what do you think? @yaira2 @hecksmosis

@yaira2
Copy link
Member

yaira2 commented Jan 4, 2023 •
edited
Loading

The progress bar looks really good

@QuaintMako
Copy link
Contributor

I am more inline with the progress bar. The progress ring just feels out of place.

@yaira2 yaira2 changed the title Fix: Add progress ring to properties when calculating sizes Feature: Added progress ring to properties to indicate when the size is calculating Jan 4, 2023
@hecksmosis
Copy link
Contributor

The progress bar feels good

yaira2
yaira2 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 5, 2023
@yaira2 yaira2 changed the title Feature: Added progress ring to properties to indicate when the size is calculating Feature: Added progress bar to properties to indicate when the size is calculating Jan 5, 2023
@yaira2 yaira2 changed the title Feature: Added progress bar to properties to indicate when the size is calculating Feature: Added progress bar to properties to indicate when the size is being calculated Jan 5, 2023
@yaira2 yaira2 merged commit 5d28bbc into files-community:main Jan 5, 2023
@ferrariofilippo ferrariofilippo deleted the Fixed_Size_Progress_Ring branch January 5, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add progress ring to properties when calculating sizes
4 participants
@ferrariofilippo @hecksmosis @yaira2 @QuaintMako