Skip to content

Fix: Fixed build pipeline certificate #10912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 4, 2023
Merged

Fix: Fixed build pipeline certificate #10912

merged 5 commits into from
Jan 4, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jan 3, 2023 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Fixed build pipeline certificate

Validation
How did you test these changes?

  • Ran the pipeline

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 requested review from marcelwgn and removed request for marcelwgn January 3, 2023 15:35
@yaira2
Copy link
Member Author

yaira2 commented Jan 3, 2023

@chingucoding besides the cert, anything else that needs to be modified?

marcelwgn
marcelwgn reviewed Jan 4, 2023
View reviewed changes
Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue is that the certificate with the CN being "Files", the old certificate had CN=FilesDev. We probably need to adjust that or update the SessionManager.cs file to reference the app through Files...!App.

@yaira2
Copy link
Member Author

yaira2 commented Jan 4, 2023

Looks like that fixed the issue, thank you!

@yaira2 yaira2 merged commit 12e0cb9 into main Jan 4, 2023
@yaira2 yaira2 deleted the ya/FixedCert branch January 4, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwgn marcelwgn marcelwgn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaira2 @marcelwgn