Fix: Fixed issue where confirm to delete would show even with the setting turned off

[ferrariofilippo]

…etting is off

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Bug: Confirmation to delete files shows in recycle bin even when setting is off #9012

Details
I changed the logic so that when the setting is off it never shows the dialog. I think this is the correct behaviour

Validation
How did you test these changes?

• Built and ran the app
• Tested the changes for accessibility

[gave92]

Aaah wait this is still wrong, if the user has the setting on the dialog should always show. Maybe:

if (showDialog && UserSettingsService.PreferencesSettingsService.ShowConfirmDeleteDialog) // Check if the setting to show a confirmation dialog is on

[jiejasonliu]

Aaah wait this is still wrong, if the user has the setting on the dialog should always show. Maybe:

if (showDialog && UserSettingsService.PreferencesSettingsService.ShowConfirmDeleteDialog) // Check if the setting to show a confirmation dialog is on

+1, if we're going the route of disabling the confirmation when it's off, we can just invert the logic entirely; the recycle bin variables aren't relevant anymore.

[gave92]

I've fixed an issue where deleting a file from network folder did not work if the dialog was turned off. Aside from that, LGTM.
Probably better if this PR gets tested by someone else as well.

[QuaintMako]

LGTM, works fine on my machine.

[yaira2]

LGTM

Resolved