Skip to content

Feature: Show notification only when app crashes #10873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Feature: Show notification only when app crashes #10873

merged 3 commits into from
Dec 29, 2022

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Dec 29, 2022

Resolved / Related Issues

  • Fixes crash notification being shown on non-critical exception.

Validation
How did you test these changes?

  • Built and ran the app

@yaira2 yaira2 changed the title Show notification only when app crashes Feature: Show notification only when app crashes Dec 29, 2022
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Dec 29, 2022
@yaira2 yaira2 merged commit 650db96 into main Dec 29, 2022
@yaira2 yaira2 deleted the d2/fx_cnotif branch December 29, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants