Skip to content

Fix: Fixed issue where the network icon was blank #10839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 26, 2022

Conversation

hecksmosis
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • [*] Built and ran the app

Screenshots (optional)
Add screenshots here.

Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some discussions around the implementations, where I'm being really picky.

Otherwise, looks good to me!

@QuaintMako
Copy link
Contributor

Heckmosis' fix works for me. Just to be sure, is this the right icon we want @yaira2 ?

10811

@yaira2
Copy link
Member

yaira2 commented Dec 25, 2022

Nope, it should use the standard folder icon.

@hecksmosis
Copy link
Contributor Author

@QuaintMako are you using a different icon set? Mine looks like this:
image

@QuaintMako
Copy link
Contributor

@QuaintMako are you using a different icon set?

The difference comes from W10 and W11.

Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the right icon for W10.

@yaira2 yaira2 changed the title Fix network icon Fix: Fixed issue where the network icon was blank Dec 26, 2022
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Dec 26, 2022
@yaira2 yaira2 merged commit 7d11b28 into files-community:main Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Missing network icon
3 participants