-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Feature: Added run as admin toggle to shortcut properties #10833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I am making this a draft because the refresh function is quite suboptimal (it refreshes everything on the page), I'm going to look for a solution but help would be appreciated. |
… runasadministrator
Could you fix the formatting that was modified by accident but has nothing to do with the PR ? Like in |
Yes, idk why but my formatting turns strange when I push changes to github |
This should not be shown/enabled for folder shotcuts. Only for shortcuts pointing to an executable. |
It is already disabled in folder shortcuts, resembling the read-only attribute, which also is disabled for folders, etc. |
I'll fix it tomorrow |
Should I try to change the refresh function? (As it is not in the main page any more, I find it unlikely that many people will change this repeatedly, and therefore it will not have a significant effect on performance) |
Turning the toggle off sometimes requires multiple clicks before it works. |
It's weird, I cannot reproduce this consistently. |
@yaira2 This looks like an issue with the xaml component, as it also happens in parts of the settings page with the same component. |
Which setting? |
The ones that use a ToggleSwitch occasionally have this issue |
It looks like a known issue: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is this ok then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
Items resolved / related issues by this PR.
Validation
How did you test these changes?