Skip to content

Feature: iCloud Drive and Photos namespace detection #10819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 25, 2022
Merged

Feature: iCloud Drive and Photos namespace detection #10819

merged 2 commits into from
Dec 25, 2022

Conversation

RuiNtD
Copy link
Contributor

@RuiNtD RuiNtD commented Dec 22, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Changes iCloud Drive to use namespace detection, so it can detect a moved iCloud Drive location.
  • Changes "iCloud" to "iCloud Drive" for consistency. (Drive is a service within iCloud and not the entirety of the service)
  • Closes iCloud Photos in Cloud Drives #10805

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
image

@yaira2 yaira2 changed the title Fix: iCloud Drive and Photos namespace detection Feature: iCloud Drive and Photos namespace detection Dec 22, 2022
@yaira2 yaira2 requested a review from gave92 December 22, 2022 22:36
gave92
gave92 reviewed Dec 22, 2022
View reviewed changes
yaira2
yaira2 reviewed Dec 23, 2022
View reviewed changes
@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Dec 24, 2022
@gave92 gave92 self-requested a review December 24, 2022 11:52
@yaira2
Copy link
Member

yaira2 commented Dec 25, 2022

LGTM

@yaira2 yaira2 merged commit 988749d into files-community:main Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gave92 gave92 gave92 approved these changes

@yaira2 yaira2 yaira2 left review comments

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iCloud Photos in Cloud Drives
3 participants
@RuiNtD @yaira2 @gave92