Codebase: Made IModifiableStorable IStorable #10817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any side effect that could emerge of it? |
|
No, there are none. Currently this interface is only used as the basis for IModifiableFile/Folder but is never used on its own. These 2 interfaces are already derived from IStorable via IFile/Folder. So that doesn't change anything for now. This will allow IModifiableStorable to be used when a more precise type is not needed. |
yaira2
changed the title
yaira2
changed the title
lukeblevins
approved these changes
Dec 25, 2022
hecksmosis
approved these changes
Dec 26, 2022
d2dyno1
approved these changes
Jan 3, 2023
d2dyno1
added
the
ready to merge
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
The interface IModifiableStorable is not IStorable. This pr repairs this oversight.
Validation
How did you test these changes?