Feature: Display banner when recent items are turned off from File Explorer

[jiejasonliu]

Resolved / Related Issues

• Closes Recent items shouldn't register elements when you have it disabled #5882

Details of Changes

• show warning banner when setting is disabled in windows
• slight refactor to empty recent files text

Validation

• Built and ran the app
• Tested the changes for accessibility

Screenshots (optional)

Files-5882.mp4

[QuaintMako]

LGTM.

[yaira2]

Should the other message be hidden in this scenario?

[jiejasonliu]

Should the other message be hidden in this scenario?

i initially had it that way, but wasn't sure. it's been changed now.

[yaira2]

The banner seems to always be open

[jiejasonliu]

The banner seems to always be open

that was the intention (if you disabled the setting), but what should be the better behavior?
we could make the banner closable and restore the text, but that raises questions on if it should be displayed once only

[yaira2]

It's showing for me even when the setting is enabled

[jiejasonliu]

It's showing for me even when the setting is enabled

one thing note is you'll have to manually refresh the widget (or navigate away) for the change to update
that said, I cannot seem to reproduce this, but it'll likely be related to the registry values

@QuaintMako if you have a chance, could you try reproducing this on your machine?
you can modify File Explorer's recent files settings by clicking the ellipsis menu > Options as seen here:

[QuaintMako]

@QuaintMako if you have a chance, could you try reproducing this on your machine? you can modify File Explorer's recent files settings by clicking the ellipsis menu > Options as seen here:

Sure thing, will try to do it soon. If I don't report in two or three days, ping me again please!

[jiejasonliu]

@yaira2 i believe the issue is resolved; it was due to an incorrect default value (registry keys don't appear unless changed once)

[yaira2]

LGTM