Skip to content

Fix: Prevent Visual Studio from stopping when deleting an item #10597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 29, 2022

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented Nov 28, 2022

Resolved / Related Issues
In debug, Visual sSudio stops at a Win32Exception necessary to know if the recycle bin can be used. This pr disables Visual Studio stops for this exception.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yaira2
Copy link
Member

yaira2 commented Dec 21, 2022

  1. How can I reproduce this issue?
  2. Can you tell Visual Studio to ignore it locally? I'm not sure we should add this to the code.

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Dec 21, 2022
@yaira2 yaira2 changed the title [Debug] Prevent Visual Studio stops when delete Fix: Prevent Visual Studio from stopping when deleting an item Dec 21, 2022
@cinqmilleans
Copy link
Contributor Author

Open Files in Debug mode, select a file, press Delete. Visual Studio stops at a Win32Exception. The code can only raise an exception regardless of the result. It is probably not possible to do otherwise.

It's fine for Visual Studio to break for a Win32Exception, but not this one. Developers shouldn't change the options, just definitely point out not to stop at this exception.

@yaira2
Copy link
Member

yaira2 commented Dec 23, 2022

I can't reproduce this
Fyi @d2dyno1

@QuaintMako
Copy link
Contributor

I can reproduce it, do you have the right exceptions activated in Visual Studio?

@yaira2
Copy link
Member

yaira2 commented Dec 23, 2022

How can I check?

@QuaintMako
Copy link
Contributor

How can I check?

Visual Studio, Press Ctrl+Alt+E and check if the Win32Exceptions are checked.

In case: https://learn.microsoft.com/en-us/visualstudio/debugger/managing-exceptions-with-the-debugger?view=vs-2022#tell-the-debugger-to-break-when-an-exception-is-thrown

@yaira2
Copy link
Member

yaira2 commented Dec 23, 2022

It's checked but it's possible I ignored this specific error.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Dec 29, 2022
@yaira2 yaira2 merged commit d848cd1 into files-community:main Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants