Skip to content

Fix: Fixed issue where the date modified wasn't shown for items inside archives #10564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 25, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Nov 25, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

Relevant SevenZipSharp commit: f8b60c0

Validation
How did you test these changes?

  • Built and ran the app

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Nov 25, 2022

Should we bring the nuget code into this repo for easier access and to better review the changes?

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Nov 25, 2022
@gave92
Copy link
Member Author

gave92 commented Nov 25, 2022

Should we bring the nuget code into this repo for easier access and to better review the changes?

Yup I proposed this some time ago, so no problem for me 👍

@gave92
Copy link
Member Author

gave92 commented Nov 25, 2022

Wait was it already there? https://github.com/files-community/SevenZipSharp. Next time I should push edits here then.

@yaira2
Copy link
Member

yaira2 commented Nov 25, 2022

We have a repo for it but I was thinking we should merge it with the main repo.

@yaira2 yaira2 merged commit 055d555 into files-community:main Nov 25, 2022
@gave92 gave92 deleted the fix_ziplib branch November 25, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants