Skip to content

Fix: Fixed issue where 7z archives were not extracted correctly #10505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2022
Merged

Fix: Fixed issue where 7z archives were not extracted correctly #10505

merged 1 commit into from
Nov 18, 2022

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Description

  • 7zip library doesn't distinct files and firectories. Because of this, they are all added to fileEntries
  • I fixed this by removing the directories from the list after they are created

Validation
How did you test these changes?

  • Built and ran the app

@yaira2 yaira2 changed the title Fixed: 7z archives are not extracted correctly Fix: Fixed issue where 7z archives were not extracted correctly Nov 18, 2022
yaira2
yaira2 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Nov 18, 2022
@yaira2 yaira2 merged commit ee42647 into files-community:main Nov 18, 2022
@gave92 gave92 mentioned this pull request Nov 25, 2022
Merged
1 task
@ferrariofilippo ferrariofilippo deleted the Archive_Bug branch December 3, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: 7z archives are not extracted correctly
2 participants
@ferrariofilippo @yaira2