Feature: Added file tags widget #10477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are any return welcomed / needed so far? |
We can use some feedback on the issue requirements |
yaira2
reviewed
Dec 18, 2022
yaira2
reviewed
Dec 18, 2022
2 tasks
yaira2
reviewed
Jan 27, 2023
ferrariofilippo
suggested changes
Jan 29, 2023
src/Files.Backend/ViewModels/Widgets/FileTagsWidget/FileTagsContainerViewModel.cs
Show resolved
Hide resolved
src/Files.Backend/ViewModels/Widgets/FileTagsWidget/FileTagsWidgetViewModel.cs
Show resolved
Hide resolved
QuaintMako
reviewed
Jan 29, 2023
src/Files.App/Filesystem/StorageEnumerators/UniversalStorageEnumerator.cs
Show resolved
Hide resolved
|
@d2dyno1 can you fix the merge conflicts? |
yaira2
previously approved these changes
Jan 30, 2023
It was built automatically by VS. Perhaps .gitignore should be updated to exclude it? @QuaintMako |
|
Don't worry about the launcher, changes to it shouldn't really matter. |
QuaintMako
approved these changes
Jan 31, 2023
yaira2
approved these changes
Jan 31, 2023
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Changes
This PR replaces Bundles widget with new tags widget based on File Tags. This PR is a work in progress.
About the widget
The widget is fully functional, but the plan is to add a toggle switch only after there is support for editing tags within the app. In the meantime, you can manually enable the widget by editing the settings file (settings > advanced > edit settings file). Please note that the app should be closed before making changes to the file.
Validation
How did you test these changes?