Skip to content

Fix: Focus first item in folder when opening it with keyboard in DetailsLayout #10439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 13, 2022
Merged

Fix: Focus first item in folder when opening it with keyboard in DetailsLayout #10439

merged 5 commits into from
Nov 13, 2022

Conversation

QuaintMako
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

What has been done

  • Now selecting the first item of a newly opened folder using Enter in DetailsLayout.
  • Changed OpenSelectedItems from async void to async Task
  • Minor refactoring.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots

9042

@QuaintMako QuaintMako changed the title 9042 wrong focus details keyboard Fix: Focus first item in folder when opening it with keyboard in DetailsLayout Nov 9, 2022
@QuaintMako QuaintMako marked this pull request as ready for review November 9, 2022 10:40
ferrariofilippo
ferrariofilippo reviewed Nov 10, 2022
View reviewed changes
ferrariofilippo
ferrariofilippo approved these changes Nov 12, 2022
View reviewed changes
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Nov 13, 2022

What happens if you navigate backwards, does it select the correct item?

@QuaintMako
Copy link
Contributor Author

It does, using the keyboard accelerator Alt+Left Arrow down here on the second item to make sure it doesn't jump on the first.

backwards

yaira2
yaira2 approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 1119635 into files-community:main Nov 13, 2022
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 13, 2022
@QuaintMako QuaintMako mentioned this pull request Dec 6, 2022
Merged
1 task
@QuaintMako QuaintMako deleted the 9042_WrongFocusDetailsKeyboard branch January 3, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@ferrariofilippo ferrariofilippo ferrariofilippo approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Navigating to folders via keyboard focuses on the name header in the details layout
3 participants
@QuaintMako @yaira2 @ferrariofilippo