Skip to content

Fix: Fixed issue where the drive letter was included in the name #10303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented Oct 26, 2022

Resolved / Related Issues
Improves PropertiesGeneral control:

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)

Rename2.mp4

@yaira2 yaira2 changed the title Improves Rename field Fix: Fixed issue where the drive letter was included in the name Oct 26, 2022
QuaintMako
QuaintMako previously approved these changes Oct 27, 2022
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few ideas to make the code a tad cleaner.
Could be integrated as it is.

cinqmilleans and others added 2 commits October 27, 2022 12:17
Co-authored-by: Quaint Mako <110472580+QuaintMako@users.noreply.github.com>
@cinqmilleans
Copy link
Contributor Author

I refactored the method with sub-methods.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 28, 2022
@yaira2 yaira2 merged commit ed9f1b3 into files-community:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants