Skip to content

Fix: Fixed issue where renaming a shortcut that had a blank name would cause a crash #10293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 26, 2022

Conversation

QuaintMako
Copy link
Contributor

Resolved / Related Issues

What has been done

  • Fixed the crash : the Replace function could not handle when item.Name was empty.
  • Did some minor refactoring.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 26, 2022
@yaira2 yaira2 changed the title Fix: Renaming a shortcut that has a blank name crashes the app Fix: Fixed issue where renaming a shortcut that had a blank name would cause a crash Oct 26, 2022
@yaira2 yaira2 merged commit ce47f0b into files-community:main Oct 26, 2022
@QuaintMako QuaintMako deleted the 10157_CrashOnRenamingEmpty branch October 31, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Renaming a shortcut that has a blank name crashes the app
2 participants