Skip to content

Fix: Fixed progress ring style in drive tooltip #10274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2022
Merged

Fix: Fixed progress ring style in drive tooltip #10274

merged 2 commits into from
Oct 23, 2022

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented Oct 22, 2022 •
edited
Loading

Resolved / Related Issues
This pr fixes the style of displaying drive sizes (Property and Tooltip).

  • In the tooltip, the background of the ring was missing.
  • In the tooltip, the 3 texts did not use exactly the same style.
  • In light mode, the color of the free space legend did not match the color used by the ring. The color of the ring has been used because it is more readable and this corresponds to the progressbar of the Drive widget.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Before Property
Before_Property_Dark
Before_Property_Light
After Property
After_Property_Dark
After_Property_Light
Before Tooltip
Before_Tooltip_Dark
Before_Tooltip_Light
After Tooltip
After_Tooltip_Dark
After_Tooltip_Light

@QuaintMako
Copy link
Contributor

LGTM.

yaira2
yaira2 reviewed Oct 23, 2022
View reviewed changes
yaira2
yaira2 reviewed Oct 23, 2022
View reviewed changes
yaira2
yaira2 approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix the style of displaying drive sizes Fix: Fixed progress ring style in drive tooltip Oct 23, 2022
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 23, 2022
@yaira2 yaira2 merged commit 63a9f44 into files-community:main Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cinqmilleans @QuaintMako @yaira2