Skip to content

Fix: Fixed issue with the text alignment in the properties window #10260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented Oct 20, 2022

Resolved / Related Issues
Fix the bad position of the text Capacity in the properties of drives.
The correct padding is 25, not 28, as the rectangle (width 15 + margin 10).

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Before/After
fixbefore
fixafter

@yaira2
Copy link
Member

yaira2 commented Oct 20, 2022

The width should be changed to 16 and the margin to 12

@yaira2 yaira2 changed the title Fix text Capacity placement Fix: Fixed issue with the text alignment in the properties window Oct 20, 2022
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Oct 20, 2022
@cinqmilleans
Copy link
Contributor Author

The changes are made. I applied the same change to the tooltip for consistency.
Capacity1
Capacity2

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Oct 20, 2022
@yaira2 yaira2 merged commit cad407c into files-community:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants