Fix: Fixed issue where settings displayed wrong language after installing Files #10222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
changed the title
|
How did you validate these changes? |
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
This pr restores Windows default in the language selection. This option is by default.
The others languages are sorted by name, including English.
Fixes #10220.
The current behavior is to select Windows default after installation, but display English in the options. It is no longer possible to return to Windows default after changing the language. This pr fixes that. Windows default should be English if the Windows language doesn't exist in Files, but I couldn't test.
The method AddSupportedAppLanguages in PreferencesViewModel is refactored.
Validation
How did you test these changes?
Screenshots (optional)
