Skip to content

Fix: Folder suggestions are not showing in the Address bar #10180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

marcofranzen99
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Comments
In #10116 the Property ItemName was removed. The property Name returns exactly the same value as ItemName did before.

Screenshots (optional)
Suggestions are displayed again
image

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 12, 2022
@yaira2 yaira2 merged commit 1800944 into files-community:main Oct 12, 2022
@marcofranzen99 marcofranzen99 deleted the 10150_folder_suggestions_not_showing branch October 12, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Folder suggestions are not showing in the Address bar
2 participants