Feature: Display error modal when shortcut target cannot be found #10130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et doesn't exist.
|
Would a very long path of the file will still look fine in the modal? Thanks! |
Currently it truncates the file path if it's too long
|
Ah, alright. Thank you! :)) |
yaira2
reviewed
Oct 6, 2022
yaira2
reviewed
Oct 6, 2022
yaira2
reviewed
Oct 6, 2022
yaira2
reviewed
Oct 6, 2022
yaira2
reviewed
Oct 6, 2022
yaira2
reviewed
Oct 6, 2022
yaira2
reviewed
Oct 6, 2022
yaira2
changed the title
yaira2
reviewed
Oct 6, 2022
yaira2
added
needs - code review
and removed
changes requested
d2dyno1
approved these changes
Oct 9, 2022
yaira2
added
ready to merge
|
@puppetsw thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Items resolved / related issues by this PR.
Validation
How did you test these changes?
Screenshots (optional)
