Skip to content

Fix: Fixed issue where preview of ANSI text didn't work #10083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Sep 29, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Fixes an issue where preview for a text file with ANSI encoding (default for notepad) does not work

Changes

  • Use StreamReader instead of DataReader as it auto-detects encoding

Validation
How did you test these changes?

  • Built and ran the app

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Sep 29, 2022
@yaira2 yaira2 changed the title Fix preview of ANSI text Fix: Fixed issue where preview of ANSI text didn't work Sep 29, 2022
@yaira2 yaira2 merged commit 4946b22 into files-community:main Sep 29, 2022
@gave92 gave92 deleted the fix_ansi branch September 29, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants