Skip to content

IUpdateService updates #10064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 28, 2022
Merged

Conversation

puppetsw
Copy link
Contributor

@puppetsw puppetsw commented Sep 25, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Removed obsolete WebClient from SideloadUpdateService
  • Updated code style.
  • Removed unused events/properties.
  • Fixed number of warnings.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

@puppetsw puppetsw marked this pull request as ready for review September 27, 2022 06:17
@puppetsw
Copy link
Contributor Author

Small updates to the sideload update service to remove the obsolete WebClient.

@yaira2
Copy link
Member

yaira2 commented Sep 28, 2022

LGTM

@yaira2 yaira2 merged commit 1e516da into files-community:main Sep 28, 2022
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants