In Sidebar Network drives>Network showing blank icon.

[shikkoku]

Description

Network drives>Network showing blank icon.

Steps To Reproduce

1. Open Flies app
2. Look up the sidebar

Expected behavior

Show up some none blank icon.

Files Version

Version: 2.3.6.0 OS Version: 10.0.22622.575

Windows Version

Windows 11 Pro Version 22H2

Relevant Assets/Logs

2022-08-13 14:58:19.1259|INFO|OnLaunched|App launched. Prelaunch: False
2022-08-13 14:58:19.5748|INFO|GetDrivesAsync|Drive added: C:, Fixed
2022-08-13 14:58:19.6157|INFO|GetDrivesAsync|Drive added: D:, Fixed
2022-08-13 14:58:19.6481|INFO|GetDrivesAsync|Drive added: E:, CDRom
2022-08-13 14:58:20.6548|INFO|CheckForUpdates|STORE: Checking for updates...
2022-08-13 14:59:13.1696|INFO|IsRunningOnArm|Running on ARM: False
2022-08-13 15:03:29.2007|INFO|OnLaunched|App launched. Prelaunch: False
2022-08-13 15:03:29.4966|INFO|GetDrivesAsync|Drive added: C:, Fixed
2022-08-13 15:03:29.5370|INFO|GetDrivesAsync|Drive added: D:, Fixed
2022-08-13 15:03:29.5669|INFO|GetDrivesAsync|Drive added: E:, CDRom
2022-08-13 15:03:30.4586|INFO|CheckForUpdates|STORE: Checking for updates...
2022-08-13 15:03:35.4895|WARN|GetSpecialProperties|Object reference not set to an instance of an object.
System.NullReferenceException: Object reference not set to an instance of an object.
at Files.Uwp.ViewModels.Properties.DriveProperties.d__5.MoveNext() + 0x587

2022-08-13 15:03:37.7694|WARN|GetSpecialProperties|Object reference not set to an instance of an object.
System.NullReferenceException: Object reference not set to an instance of an object.
at Files.Uwp.ViewModels.Properties.DriveProperties.d__5.MoveNext() + 0x587

2022-08-13 15:03:56.1478|INFO|IsRunningOnArm|Running on ARM: False
2022-08-13 15:03:59.8677|INFO|OnLaunched|App launched. Prelaunch: False
2022-08-13 15:04:00.1696|INFO|GetDrivesAsync|Drive added: C:, Fixed
2022-08-13 15:04:00.2125|INFO|GetDrivesAsync|Drive added: D:, Fixed
2022-08-13 15:04:00.2424|INFO|GetDrivesAsync|Drive added: E:, CDRom
2022-08-13 15:04:01.1594|INFO|CheckForUpdates|STORE: Checking for updates...
2022-08-13 15:04:02.1833|INFO|IsRunningOnArm|Running on ARM: False
2022-08-13 15:04:31.8286|INFO|OnLaunched|App launched. Prelaunch: False
2022-08-13 15:04:32.1723|INFO|GetDrivesAsync|Drive added: C:, Fixed
2022-08-13 15:04:32.2131|INFO|GetDrivesAsync|Drive added: D:, Fixed
2022-08-13 15:04:32.2426|INFO|GetDrivesAsync|Drive added: E:, CDRom
2022-08-13 15:04:33.2389|INFO|CheckForUpdates|STORE: Checking for updates...
2022-08-13 15:05:24.3801|INFO|IsRunningOnArm|Running on ARM: False
2022-08-13 15:05:53.3807|INFO|OnLaunched|App launched. Prelaunch: False
2022-08-13 15:05:53.6779|INFO|GetDrivesAsync|Drive added: C:, Fixed
2022-08-13 15:05:53.7216|INFO|GetDrivesAsync|Drive added: D:, Fixed
2022-08-13 15:05:53.7545|INFO|GetDrivesAsync|Drive added: E:, CDRom
2022-08-13 15:05:54.7585|INFO|CheckForUpdates|STORE: Checking for updates...
2022-08-13 15:09:37.8730|INFO|OnLaunched|App launched. Prelaunch: False
2022-08-13 15:09:38.1914|INFO|GetDrivesAsync|Drive added: C:, Fixed
2022-08-13 15:09:38.2333|INFO|GetDrivesAsync|Drive added: D:, Fixed
2022-08-13 15:09:38.2638|INFO|GetDrivesAsync|Drive added: E:, CDRom
2022-08-13 15:09:39.2668|INFO|CheckForUpdates|STORE: Checking for updates...
2022-08-13 15:10:56.5691|INFO|OnActivated|App activated by Protocol
2022-08-13 15:10:57.2068|INFO|IsRunningOnArm|Running on ARM: False
2022-08-13 15:10:57.8733|INFO|CheckForUpdates|STORE: Checking for updates...

[DavidPerikala]

Hey, I am new to contributing and would like to work on this issue.

So basically, the constructor for the class NetworkDrivesManager at $Files.Uwp\Filesystem\NetworkDrivesManager.cs, creates and adds a dummy Network drive? Is there a reason for it?

Removing this code solves this issue. How should we proceed?

[Josh65-2201]

The folder is to show network devices like file explorer. Also you should only work on issues that have the "triage approved" label.

[shikkoku]

The folder is to show network devices like file explorer. Also you should only work on issues that have the "triage approved" label.

I don't have any Network Drives. Only have one upnp router devices.

[Josh65-2201]

I know you dont. Its not a network drive it simple the scan for network devices option.

[DavidPerikala]

1. Sure, Got it.
2. Sounds like we are on a different page.
   Issue is about a network drive item [Refer 2 in the image], It is clearly not a scan option, since the code behind is literally a Drive Item.
   
3. Refer the code which is behind this network drive, with network drive properties and name as "Network"
   

[Josh65-2201]

It is. if you enabled network discovery in windows and clicked on it then you would see it was. Either way this issue is about the icon and not the function.

Asking @yaichenbaum for approval.

[yaira2]

Hey, I am new to contributing and would like to work on this issue.

So basically, the constructor for the class NetworkDrivesManager at $Files.Uwp\Filesystem\NetworkDrivesManager.cs, creates and adds a dummy Network drive? Is there a reason for it?

Removing this code solves this issue. How should we proceed?

This code is necessary, there seems to be an issue where it's not working to load the correct icon, do you want to look into this?

[DavidPerikala]

Thank you, Sure I will work on it.

[DavidPerikala]

@yaichenbaum, I have reused the existing Network drive icon. Is this okay?

[yaira2]

@DavidPerikala that or a maybe a folder would be better 👍