Bug: Thumbnails are displayed in the wrong aspect ratio

[gave92]

Description

Issue #8128 is back. Thumbnails of images are cropped into squares.

Fixed in #5717, reintroduced (probably) in #5842.

Steps To Reproduce

1. Navigate to a folder with images
2. Switch to any grid layout
3. See that image thumbnails are displayed as squares

Expected behavior

• Thumbnails should display with the correct aspect ratio in the grid layouts

Files Version

main (2.2.5)

Windows Version

OS Version: 10.0.19043.1110

Relevant Assets/Logs

[cinqmilleans]

@gave92 I had already looked at what was possible. The native Thumbnail generator currently used does not allow it, or only with a 0.7 vertical ratio.

Here is a system that works for videos, without using external libraries http://blog.bagusandryan.com/get-video-thumbnail-storagefile-uwp-732/. Another system is needed for images (and possibly other documents).

You can also add decorations for Thumbnails (like Finder for MacOs). https://support.apple.com/library/content/dam/edam/applecare/images/fr_FR/macos/Big-Sur/macos-big-sur-finder-add-folder-sidebar.jpg.

I also tested with a large CornerRadius in large icons, it looks really nice.

[cinqmilleans]

@gave92 After checking, it is possible to have the correct ratio by using ThumbnailMode.SingleItem. But it doesn't work if thumbnails are disabled in File Explorer.

[gave92]

Yeah SingleItem in known to work from #5717. But it creates some other issue.. possibly that it breaks icons in details view, i don't remember.

[gave92]

Edit: looks like PR #7881 changed mode from SingleItem to DocumentsView to fix thumbnails generated by SageThumbs.

[Josh65-2201]

Asking @yaichenbaum for approval.