favorites do not update on other windows

[modest-marmot]

Description

when i add a favorite in one window it does not update the favorite lists in other windows. new list only propagates to windows created after the favorite is added.

Steps To Reproduce

1. create (2) new windows
2. pin a favorite to one of the windows
3. note that favorite list on second window does not update
4. open 3rd window - favorite now shows up properly

Expected behavior

favorites update in all windows when added in another.

Files Version

Version: 2.1.15.0 OS Version: 10.0.19044.1526

Windows Version

Edition Windows 10 Pro Version 21H2 Installed on ‎12/‎25/‎2020 OS build 19044.1526 Experience Windows Feature Experience Pack 120.2212.4170.0

Relevant Assets/Logs

debug.log

[jiejasonliu]

Had a glance at this, problem is that new windows have their own SidebarPinnedController but we serialize favorites into PinnedItems.json. Since this is a push strategy, this won't be propagated to other windows.

The most reasonable solution I can think of is a FileSystemWatcher (or some other polling strategy) to track changes and force an update. But this seems to be an issue that could reoccur elsewhere so I'm not sure if an isolated patch would be a good idea.

[yaira2]

This issue should be resolved with #8712