Save favorites in the settings json

[Josh65-2201]

Description

My files (2.0.36) has vertical tabs button off but when importing to files (2.0.39) it gets turned on again. Side bar pins and home screen widgets don't get saved or applied if they are saved.

Steps To Reproduce

No response

Expected behavior

It should correctly apply/save settings stated above

Files Version

2.0.39.0

Windows Version

10.0.19043.1348

Relevant Assets

debug.log
debug_fulltrust.log

[yaira2]

The sidebar favorites are considered settings and are stored in a different file but perhaps we can merge them into the settings file.

[gave92]

@yaichenbaum What do you think of exporting all settings in a .zip file? I've pushed a test branch here that imports/exports all settings to/from a zip file.
It includes: pinned items, user settings, file tags, terminal profiles, bundles. All settings are applied without restart.

[yaira2]

@gave92 that's a great idea! I think we can remove the terminal settings and default to the system terminal.

[gave92]

Do you mean merging them only when exporting or also in the app? If we merged the terminal profile with the main settings, clicking on "Edit Terminals" would open a file full of stuff not related to terminals.

[yaira2]

Do you mean merging them only when exporting or also in the app? If we merged the terminal profile with the main settings, clicking on "Edit Terminals" would open a file full of stuff not related to terminals.

@gave92 I edited my original message.