Wrong selection for deleting permanently with "del" key

[tellmewhy12]

Description

Bug 1:
"Delete permanently" gets selected instead of "Delete" on the bottom.

Bug 2:
Pressing enter does not select "Delete permanently" but triggers the "Delete" button

Steps To Reproduce

No response

Expected behavior

/

Files Version

Version: 1.9.21.0 OS Version: 10.0.19043.1110

Windows Version

Win10Home21H1

Relevant Assets

/

[gave92]

Well, this is the fastest you can get using the keyboard: "Space" toggles permanent delete while "Enter" confirms it ;)

But I agree keyboard focus should be on the Delete button.

[tellmewhy12]

Well, this is the fastest you can get using the keyboard: "Space" toggles permanent delete while "Enter" confirms it ;)

But I guess it's true keyboard focus should be on the Delete button.

I agree that it is really fast :P but probably not what the general user expects and because deleting files is a sensitive functionality, having it unexpectedly delete a file instead of ticking a box might scare users

[yaira2]

@mangoepic can this be merged with #5584?

[tellmewhy12]

@yaichenbaum However it's easier for you guys to handle ^^

This issue here was also about not accidentally hitting "confirm delete" via enter while the checkbox is focused but depending on what you want to do it's definitely overlapping

[gave92]

I'm not sure what changed but hitting enter does not seem to confirm delete, so perhaps the relevant issue now is only #5584.

[tellmewhy12]

I'm not sure what changed but hitting enter does not seem to confirm delete, so perhaps the relevant issue now is only #5584.

only in recyclebin

[d2dyno1]

@mangoepic Fixed with #7882