Code Quality: Enforce `AppDialogService` usage across the codebase

[Lamparter]

Description

The DialogService in Files.App.Services unifies dialogues across the app, however the service isn't used in all parts of the app itself (some classes manually instantiate and handle a ContentDialog instance).

Concerned code

~ Code search results ("new ContentDialog")

Gains

• Unification of dialogues across codebase
• Use of existing service

Requirements

• Reimplement dialogues via DialogService

---

Files/src/Files.App/Helpers/BitmapHelper.cs

Line 95 in 874a33d

var errorDialog = new ContentDialog()

Files/src/Files.App/Actions/Open/OpenLogFileAction.cs

Line 45 in 874a33d

var errorDialog = new ContentDialog()

Files/src/Files.App/Actions/Open/OpenSettingsFileAction.cs

Line 40 in 874a33d

var errorDialog = new ContentDialog()

Files/src/Files.App/Actions/FileSystem/EmptyRecycleBinAction.cs

Line 41 in 874a33d

var confirmationDialog = new ContentDialog()

Files/src/Files.App/Actions/FileSystem/RestoreRecycleBinAction.cs

Line 38 in 874a33d

var confirmationDialog = new ContentDialog()

Files/src/Files.App/Actions/Content/Background/BaseSetAsAction.cs

Line 37 in 874a33d

var errorDialog = new ContentDialog()

Files/src/Files.App/Actions/FileSystem/CreateAlternateDataStreamAction.cs

Line 58 in 874a33d

var dialog = new ContentDialog

Files/src/Files.App/Actions/FileSystem/FlattenFolderAction.cs

Line 48 in 874a33d

var optionsDialog = new ContentDialog()

Files/src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs

Line 656 in 874a33d

var ItemAlreadyExistsDialog = new ContentDialog()

Files/src/Files.App/Actions/FileSystem/RestoreAllRecycleBinAction.cs

Line 50 in 874a33d

var errorDialog = new ContentDialog()

Files/src/Files.App/Services/App/AppUpdateStoreService.cs

Line 164 in 874a33d

ContentDialog dialog = new()

Files/src/Files.App/Helpers/ShareItemHelpers.cs

Line 36 in 874a33d

var errorDialog = new ContentDialog()

Files/src/Files.App/Utils/FileTags/FileTagsHelper.cs

Line 43 in 874a33d

ContentDialog dialog = new()

[yaira2]

@Lamparter the dialog service is designed for reusable dialogs. For simple dialogs that are a one off, the regular api is fine.

[Lamparter]

Given that most of these are error dialogues (they share a common purpose), wouldn't it make sense to use the dialogue service?

[yaira2]

If the dialogs are the same, yes 👍