Bug: Directly opening library files invokes explorer.exe

[el-ev]

Description

When a user directly open a library file, it opens in Windows Explorer instead of in the Files, even if Files is set as the default file manager.

Steps To Reproduce

1. Set Files as the default file manager
2. Open ~\AppData\Roaming\Microsoft\Windows\Libraries
3. Double-click on any library (.library-ms) file
4. The library opens in explorer.exe
   (Note: “Right-click -> Open in new tab” works fine)

Requirements

The library should open in Files like a common folder

Files Version

3.0.16.0

Windows Version

10.0.19045.3803

Log File

.

[MinaHansen]

I have managed to reproduce the issue partially but in my case, it does not open when I double-click the Library files.
opening in new tab works as expected.

I will try to diagnose and fix the issue.

[MinaHansen]

It looks like opening library folders is not supported yet so it falls back on explorer.exe to open it.

It looks like I can add this feature fairly easily.

Edit:
Can someone add the Enhancement label or something similar?

[MinaHansen]

On second thought it looks like someone forgot to add this for double-clicking.

[el-ev]

There's a similar thing with .search-ms files, which are probably rarely used, but they can be created by the "Save Search" feature in Explorer. Opening them in Explorer starts the saved search, while opening them in Files results in a NotAFolder error.

Saved Search File Format

[Josh65-2201]

Thanks for the report, I've added this to the project board.

[MinaHansen]

I traced the issue back to this method

// File: BaseStorageFolder.cs
public static IAsyncOperation<BaseStorageFolder> GetFolderFromPathAsync(string path)
{
	return
		AsyncInfo.Run(async (cancellationToken)
			=> await ZipStorageFolder.FromPathAsync(path) ?? await FtpStorageFolder.FromPathAsync(path) ?? await ShellStorageFolder.FromPathAsync(path) ?? await SystemStorageFolder.FromPathAsync(path));
}

There is a missing implementation here.
It does not know how to handle paths to library files.

[yaira2]

@SakuraKade thanks for the investigation, would you like to work on a fix?

[MinaHansen]

I am not familiar with the codebase, but I can work on a fix if it gets some pointers.

[MinaHansen]

Looks like I have to continue tomorrow.

[MinaHansen]

For later reference where should I add the fix?
Should I add it as another StorageFolder type or
should I implement the fix into one of the existing ones?