Bug: The length of tag names is not limited

[hishitetsu]

Description

The length of tag names is not limited. If I create a new tag with too long name, the Edit and Delete buttons are no longer visible and the app becomes unstable.

Steps To Reproduce

1. Create a new tag with too long name.
2. The Edit and Delete buttons are no longer visible and the app becomes unstable.

Requirements

There should be a length limit on tag names.

Files Version

2.5.10.0

Windows Version

10.0.19044.3086

Log File

n/a

[QuaintMako]

What should the limit be? Something arbitrary?

[hishitetsu]

Yes, it's arbitary. I think 64 characters is enough.

[mdtauk]

This also brings up another question, do we truncate with an ellipses, or wrap these tag labels?

[hishitetsu]

It would be better to truncate with an ellipses since the full name is displayed on a tooltip when the cursor is hovered over the tag.

[mdtauk]

It would be better to truncate with an ellipses since the full name is displayed on a tooltip when the cursor is hovered over the tag.

Character limits seem like an obvious fix, but languages like German use very long word combinations, so a limit for one language, may be too much for another.

[hishitetsu]

I see, then 256 characters limit is sufficient, isn't it? In any case, I think the limit is necessary to avoid making the app unstable.
256 characters tag name doesn't seem to make the app unstable.

[QuaintMako]

I'd suggest combining both ideas : limit to 256 characters, and implement a mechanism of wrapping in the Tags edition?

[mdtauk]

I see, then 256 characters limit is sufficient, isn't it? In any case, I think the limit is necessary to avoid making the app unstable. 256 characters tag name doesn't seem to make the app unstable.

256 is a fair number, but you can truncate the characters displayed also.

[mdtauk]

I'd suggest combining both ideas : limit to 256 characters, and implement a mechanism of wrapping in the Tags edition?

Wrapping may be possible too, but that may have an impact on row heights, and so truncating with an ellipses, may have to suffice.

[Lukiluc29]

I wanted to modify a label that I saved, but after trying to modify it again, the edition does not work. I don't know if it's related to the number of characters.

[mdtauk]

I think its also worth looking at how we present the tags, I think @yaira2 was happy with this idea I proposed when we were looking at the sidebar design.

Removing the pill border will save some space also

[hishitetsu]

I wanted to modify a label that I saved, but after trying to modify it again, the edition does not work. I don't know if it's related to the number of characters.

That is because the tag name is too long and hides the text box, so truncating with an ellipses will solve the problem.