Bug: System.AccessViolationException in ContextMenu

[btomblinson]

Description

I was trying to work on issue #11580 but when I right click on a file or a folder and try to make an archive of it, Files crashes with the attached error.

I am running the master branch using the latest code. I even tried checking out v2.4.40 tag/release since that was the version mentioned on the issue and I still get the same error.

Recording.2023-04-15.190617.mp4

Steps To Reproduce

Run latest code
Right click on a file or folder and select archive

Requirements

Do not crash when trying to archive a file/ folder

Files Version

master

Windows Version

Windows 11 22H2

Log file

Log doesn't show much

debug.log

[yaira2]

Thank you for reporting this issue, this happens for me as well and I mentioned it to @hishitetsu but they can't reproduce it so it might be device specific.

[btomblinson]

@yaira2 are you using Windows 10 or 11? Might be a Windows 11 bug. I can try to run on a Windows 10 machine if necessary. Regardless it’s definitely a major issue on Windows 11 since it prevents users from creating archive files.

[yaira2]

Windows 11, I should note that it's only in debug mode. I can't reproduce the issue in release.

[hishitetsu]

I don't think this is an archive file creation issue, but a shell extension loading issue.
There is the following workaround in the same class. Do we need the same workaround here?

Files/src/Files.App/Shell/ContextMenu.cs

Lines 316 to 319 in ac31532

	// Hackish workaround to avoid an AccessViolationException on some items,
	// notably the "Run with graphic processor" menu item of NVidia cards
	if (offset > 5000)
	return null;

However, if it only happens in debug mode, I would like to leave it as is without extra workarounds.

[btomblinson]

Yeah I just noticed it because I was trying to work on #11580 so I was running in debug and using the context menu to select create archive. I have no issue with adding a “hack” to get around it if that’s the only option. Could also use #if debug pre processor so the hack is only used in debug build configuration

[hishitetsu]

@btomblinson Can you try to add the hack if possible? I can't confirm if it works as I can't reproduce.

[btomblinson]

Well now that I look at it more, on line 273 of contextmenu, should we just add the accessviolationexception to the catch so we just ignore it? Only concern is if it causes downstream problems but I can test that. Instead of adding a “hack” around that try catch like you mentioned we do further down