Skip to content

Code Quality: Correct namespaces #11257

Closed as not planned
Closed as not planned
@0x5bfa

Description

@0x5bfa

Description

I'd like to work on #4180 by reorganizing namespaces and I'd like you guys to feedback one by one whether it is able to be implemented.

Summary

0. Correct those namespaces in Files.App

Change models:

'Views/SettingsPages/*.xaml(.cs)'        ->   'Views/Settings/*Page.xaml(.cs)'
'Views/Pages/Properties*.xaml(.cs)'      ->   'Views/Properties/*Page.xaml(.cs)'
'ViewModels/Properties/*Properties.cs'   ->   'ViewModels/Properties/*ViewModel.cs'
'ViewModels/SettingsViewModels/*.cs'     ->   'ViewModels/Settings/*.cs'
'ViewModels/Dialogs/*DialogViewModel.cs' ->   'ViewModels/Dialogs/*ViewModel.cs'

Preview samples:

'Views/SettingsPages/Appearance.xaml'   ->   'Views/Settings/AppearancePage.xaml'
'Views/Pages/PropertiesSecurity.xaml'   ->   'Views/Properties/SecurityPage.xaml'
'ViewModels/SettingsViewModels/AppearanceViewModel.cs' -> 'ViewModels/Settings/AppearanceViewModel.cs'
'ViewModels/Properties/SecurityProperties.cs'          -> 'ViewModels/Properties/SecurityViewModel.cs'
'ViewModels/Dialogs/CreateShortcutDialogViewModel.cs'  -> 'ViewModels/Dialogs/CreateShortcutViewModel.cs'

1. Merge 'Files.Backend' and 'Files.Shared' into 'Files.Core' (, which is new)

  • Files.Backend -> Files.Core
  • Files.Shared -> Files.Core (merge into Core)

5. Move 'Files.App.CommandLine'

  • Files.App.CommandLine -> Files.Core.CommandLine

6. Move UI-unrelated 'Files.App.Helpers' and 'Files.App.Extensions'

  • Files.App.Helpers -> Files.Core.Helpers
  • Files.App.Extensions -> Files.Core.Extensions

7. Merge 'Files.App.AppModels' into 'DataModels' (, which is existing already)

  • Files.App.AppModels -> Files.App.DataModels

8. Merge 'Files.App.ValueConverters' into 'Files.App.Converters' (, which is existing already)

  • Files.App.ValueConverters -> Files.App.Converters

Concerned code

Not codes but namespaces.

Gains

  • A better accessible/predictable namespaces.

Requirements

  • Rename those with VS 2022 search/replace functionality.

Comments

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    Status

    ✅ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions