Skip to content

Commit 580ed86

Browse files
authored
Code Quality: Refactor IncreaseLayoutSize (#14677)
1 parent b7d2f18 commit 580ed86

File tree

10 files changed

+139
-203
lines changed

10 files changed

+139
-203
lines changed

src/Files.App/Data/Contexts/DisplayPage/DisplayPageContext.cs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,13 @@ public LayoutTypes LayoutType
3434
viewModel.ToggleLayoutModeTiles(true);
3535
break;
3636
case LayoutTypes.GridSmall:
37-
viewModel.ToggleLayoutModeGridViewSmall(true);
37+
viewModel.ToggleLayoutModeGridView(GridViewSizeSmall, true);
3838
break;
3939
case LayoutTypes.GridMedium:
40-
viewModel.ToggleLayoutModeGridViewMedium(true);
40+
viewModel.ToggleLayoutModeGridView(GridViewSizeMedium, true);
4141
break;
4242
case LayoutTypes.GridLarge:
43-
viewModel.ToggleLayoutModeGridViewLarge(true);
43+
viewModel.ToggleLayoutModeGridView(GridViewSizeLarge, true);
4444
break;
4545
case LayoutTypes.Columns:
4646
viewModel.ToggleLayoutModeColumnView(true);
@@ -141,12 +141,13 @@ public DisplayPageContext()
141141
public void DecreaseLayoutSize()
142142
{
143143
if (FolderSettings is LayoutPreferencesManager viewModel)
144-
viewModel.GridViewSize -= GridViewIncrement;
144+
viewModel.DecreaseLayoutSize();
145145
}
146+
146147
public void IncreaseLayoutSize()
147148
{
148149
if (FolderSettings is LayoutPreferencesManager viewModel)
149-
viewModel.GridViewSize += GridViewIncrement;
150+
viewModel.IncreaseLayoutSize();
150151
}
151152

152153
private void Context_Changing(object? sender, EventArgs e)
@@ -173,7 +174,7 @@ private void FolderSettings_PropertyChanged(object? sender, PropertyChangedEvent
173174
switch (e.PropertyName)
174175
{
175176
case nameof(LayoutPreferencesManager.LayoutMode):
176-
case nameof(LayoutPreferencesManager.GridViewSize):
177+
case nameof(LayoutPreferencesManager.IconSize):
177178
case nameof(LayoutPreferencesManager.IsAdaptiveLayoutEnabled):
178179
SetProperty(ref _LayoutType, GetLayoutType(), nameof(LayoutType));
179180
break;
@@ -250,12 +251,11 @@ private LayoutTypes GetLayoutType()
250251
FolderLayoutModes.DetailsView => LayoutTypes.Details,
251252
FolderLayoutModes.ListView => LayoutTypes.List,
252253
FolderLayoutModes.TilesView => LayoutTypes.Tiles,
253-
FolderLayoutModes.GridView => viewModel.GridViewSizeKind switch
254+
FolderLayoutModes.GridView => viewModel.IconSize switch
254255
{
255-
GridViewSizeKind.Small => LayoutTypes.GridSmall,
256-
GridViewSizeKind.Medium => LayoutTypes.GridMedium,
257-
GridViewSizeKind.Large => LayoutTypes.GridLarge,
258-
_ => throw new InvalidEnumArgumentException(),
256+
< GridViewSizeMedium => LayoutTypes.GridSmall,
257+
< GridViewSizeLarge => LayoutTypes.GridMedium,
258+
_ => LayoutTypes.GridLarge,
259259
},
260260
FolderLayoutModes.ColumnView => LayoutTypes.Columns,
261261
_ => throw new InvalidEnumArgumentException(),

src/Files.App/Helpers/Layout/AdaptiveLayoutHelpers.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public static void ApplyAdaptativeLayout(LayoutPreferencesManager folderSettings
3030
folderSettings.ToggleLayoutModeDetailsView(false);
3131
break;
3232
case Layouts.Grid:
33-
folderSettings.ToggleLayoutModeGridView(folderSettings.GridViewSize);
33+
folderSettings.ToggleLayoutModeGridView(Constants.Browser.GridViewBrowser.GridViewSizeMedium, false);
3434
break;
3535
}
3636
}

0 commit comments

Comments
 (0)