Skip to content

Code Quality: Refactor IncreaseLayoutSize #14677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2024
Merged

Code Quality: Refactor IncreaseLayoutSize #14677

merged 1 commit into from
Feb 11, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Feb 8, 2024 •
edited
Loading

Resolved / Related Issues

Validated

  • Confirmed that adaptive layout is working correctly
  • Confirmed that you can use ctrl ++ and ctrl +- to switch between layouts
  • Confirmed that you can override layouts

@ferrariofilippo
Copy link
Contributor

I found a bug:

  1. Set GridView
  2. Increase to max size
  3. Set a different layout (Details/List/Tiles)
  4. Click on Small Grid
  5. See that Large Grid is selected
Screen_Record.mp4

@yaira2
Copy link
Member Author

yaira2 commented Feb 9, 2024

That should be fixed now

@yaira2 yaira2 requested a review from 0x5bfa February 9, 2024 01:48
0x5bfa
0x5bfa approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as in codebase quality (not tested on the local).

Below is just an idea; depends on you if you change

ferrariofilippo
ferrariofilippo approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me

hishitetsu
hishitetsu approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 580ed86 into main Feb 11, 2024
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 11, 2024
@yaira2 yaira2 deleted the ya/IconSize branch February 11, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x5bfa 0x5bfa 0x5bfa approved these changes

@hishitetsu hishitetsu hishitetsu approved these changes

@ferrariofilippo ferrariofilippo ferrariofilippo approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yaira2 @ferrariofilippo @0x5bfa @hishitetsu