Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #790 #793

Merged
merged 4 commits into from
Nov 15, 2021
Merged

Fix Issue #790 #793

merged 4 commits into from
Nov 15, 2021

Conversation

bcheidemann
Copy link
Contributor

This fixes issue #790 by exposing the FilerWebpackPlugin class through it's own import.

var { FilerWebpackPlugin } = require('filer/webpack');

It also deprecates the following:

var { FilerWebpackPlugin } = require('filer');

And updates the documentation in README.md to reflect these changes.

@bcheidemann
Copy link
Contributor Author

@humphd what do you think?

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. @thomas-jakemeyn, do you have any input for your use case?

@humphd humphd merged commit 7efc4cd into filerjs:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants