Regression test and fix for issue #773

[bcheidemann]

Adds a test which currently fails, demonstrating issue #773

[humphd]

Let's fix this while you're adding this test.

I think the easiest thing would be to mimic what node does here:

diff --git a/src/filesystem/implementation.js b/src/filesystem/implementation.js
index 3027688..67bc8c0 100644
--- a/src/filesystem/implementation.js
+++ b/src/filesystem/implementation.js
@@ -1873,8 +1873,8 @@ function writeFile(context, path, data, options, callback) {
   if(typeof data === 'number') {
     data = '' + data;
   }
-  if(typeof data === 'string' && options.encoding === 'utf8') {
-    data = Buffer.from(data);
+  if(typeof data === 'string') {
+    data = Buffer.from(data, options.encoding || 'utf8');
   }

   open_file(context, path, flags, function(err, fileNode) {

Node does a bit more work to assert the encoding, but I don't know if we care beyond making sure we set the default encoding to 'utf8' if it's missing.

[bcheidemann]

Let's fix this while you're adding this test.

I think the easiest thing would be to mimic what node does here:

diff --git a/src/filesystem/implementation.js b/src/filesystem/implementation.js
index 3027688..67bc8c0 100644
--- a/src/filesystem/implementation.js
+++ b/src/filesystem/implementation.js
@@ -1873,8 +1873,8 @@ function writeFile(context, path, data, options, callback) {
   if(typeof data === 'number') {
     data = '' + data;
   }
-  if(typeof data === 'string' && options.encoding === 'utf8') {
-    data = Buffer.from(data);
+  if(typeof data === 'string') {
+    data = Buffer.from(data, options.encoding || 'utf8');
   }

   open_file(context, path, flags, function(err, fileNode) {

Node does a bit more work to assert the encoding, but I don't know if we care beyond making sure we set the default encoding to 'utf8' if it's missing.

I've implemented the equivalent of what node is doing, should be good to review now =)

[bcheidemann]

Closes #773

[bcheidemann]

@humphd I moved this line of code so that data = 0 would be handled the same as other numbers.

[humphd]

Excellent, thank you.

At some point it would be good to do follow-ups in the future that add tests for these new code paths (data being an Object for the .toString() call, using other encodings, etc).