Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: impl std Error for StartError #6

Merged
merged 1 commit into from
Jun 7, 2023
Merged

fix: impl std Error for StartError #6

merged 1 commit into from
Jun 7, 2023

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Jun 7, 2023

Also extract StartError code into a standalone file.

After this change, we can use anyhow's context extension to convert StartError instances to anyhow instances.

@bajtos
fix: impl std Error for StartError
ad3bb99 
Also extract StartError code into a standalone file.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos force-pushed the fix-error-types branch from 90a2c67 to ad3bb99 Compare June 7, 2023 09:07
@bajtos bajtos requested a review from juliangruber June 7, 2023 09:11
@bajtos bajtos merged commit 3c91f12 into main Jun 7, 2023
@bajtos bajtos deleted the fix-error-types branch June 7, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliangruber juliangruber Awaiting requested review from juliangruber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bajtos