Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cmd: sort actor CIDs alphabetically before printing #6244

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

simlecode
Copy link
Collaborator

关联的Issues (Related Issues)

close #6204

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode force-pushed the chore/sort-before-output branch from 674f3e3 to c3bf89f Compare December 5, 2023 08:38
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Merging #6244 (c3bf89f) into master (bc5cf50) will increase coverage by 0%.
The diff coverage is 0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6244   +/-   ##
======================================
  Coverage      25%     25%           
======================================
  Files         636     636           
  Lines       78031   78052   +21     
======================================
+ Hits        20242   20253   +11     
- Misses      55121   55133   +12     
+ Partials     2668    2666    -2     

Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit d85a8d7 into master Dec 5, 2023
3 checks passed
@LinZexiao LinZexiao deleted the chore/sort-before-output branch December 5, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ux] sort actor before printing / actor 打印前按字母排序
3 participants