Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: remove CachedBlockstore #6218

Merged
merged 1 commit into from
Nov 28, 2023
Merged

opt: remove CachedBlockstore #6218

merged 1 commit into from
Nov 28, 2023

Conversation

simlecode
Copy link
Collaborator

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode marked this pull request as draft November 9, 2023 09:12
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

Merging #6218 (5e02608) into master (0c8c472) will increase coverage by 0%.
The diff coverage is 0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6218   +/-   ##
======================================
  Coverage      25%     25%           
======================================
  Files         636     636           
  Lines       78075   78061   -14     
======================================
+ Hits        20203   20221   +18     
+ Misses      55200   55172   -28     
+ Partials     2672    2668    -4     

@simlecode simlecode force-pushed the opt/remove-cache-store branch from b1c6a1c to 12cd43c Compare November 22, 2023 05:21
@simlecode simlecode force-pushed the opt/remove-cache-store branch from 12cd43c to 5e02608 Compare November 28, 2023 07:24
@simlecode simlecode marked this pull request as ready for review November 28, 2023 07:24
Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit 8733a7e into master Nov 28, 2023
2 checks passed
@LinZexiao LinZexiao deleted the opt/remove-cache-store branch November 28, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants