Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set gcConfidence = 2 * constants.ForkLengthThreshold / 设置gcConfidence的值为2 * constants.ForkLengthThreshold #6113

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

elvin-du
Copy link
Collaborator

关联的Issues (Related Issues)

close #6112

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@elvin-du elvin-du requested a review from simlecode August 21, 2023 09:45
@elvin-du elvin-du self-assigned this Aug 21, 2023
@elvin-du elvin-du added the C-bug Category: This is a bug label Aug 21, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #6113 (5252965) into master (64a8fcd) will increase coverage by 0%.
The diff coverage is 50%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6113   +/-   ##
======================================
  Coverage      24%     24%           
======================================
  Files         662     662           
  Lines       80582   80581    -1     
======================================
+ Hits        19706   19724   +18     
+ Misses      58258   58243   -15     
+ Partials     2618    2614    -4     

@simlecode simlecode added the nv21 合并 nv21 网络升级相关代码 label Aug 22, 2023
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode changed the base branch from master to feat/nv21 August 22, 2023 01:24
@simlecode simlecode merged commit 9acf862 into feat/nv21 Aug 22, 2023
@simlecode simlecode deleted the fix/elvindu/fix-event-subscription branch August 22, 2023 01:24
@Fatman13 Fatman13 removed this from the Sophon v1.14.0 / 智子 v1.14.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug nv21 合并 nv21 网络升级相关代码
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: events: don't set GC confidence to 1 / 默认confidence值不要设置为1
4 participants