Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove MinPeerThreshold in bootstrap config because it is not used /删除MinPeerThreshold字段从bootstrap配置,没有用到 #6063

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

elvin-du
Copy link
Collaborator

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@elvin-du elvin-du added the C-enhancement Category: feature enhancement label Jul 11, 2023
@elvin-du elvin-du requested review from LinZexiao and simlecode July 11, 2023 07:58
@elvin-du elvin-du self-assigned this Jul 11, 2023
@simlecode
Copy link
Collaborator

@elvin-du ci 没过

@codecov-commenter
Copy link

Codecov Report

Merging #6063 (97b04d5) into master (d4b62f6) will increase coverage by 0%.
Report is 22 commits behind head on master.
The diff coverage is 84%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #6063    +/-   ##
=======================================
  Coverage      24%     24%            
=======================================
  Files         661     662     +1     
  Lines       80244   80352   +108     
=======================================
+ Hits        19646   19677    +31     
- Misses      57998   58064    +66     
- Partials     2600    2611    +11     

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit 39d041d into master Aug 15, 2023
@simlecode simlecode deleted the opt/elvindu/remove-bootstrap-MinPeerThreshold-field branch August 15, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: feature enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants