Reduce functional test parallelism to 2. Hold Codecov reports until all builds complete. #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll builds complete.
Codecov Report
@@ Coverage Diff @@
## master #3414 +/- ##
=======================================
- Coverage 48% 46% -3%
=======================================
Files 230 230
Lines 14341 14341
=======================================
- Hits 6944 6612 -332
- Misses 6372 6766 +394
+ Partials 1025 963 -62 |
travisperson
approved these changes
Sep 12, 2019
|
The coverage reported above does not inspire confidence. But I'm not sure if we need the changes to be on the base branch, master, to make the difference? Anyway, this is less wrong. |
frrist
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're still seeing some coverage reports that appear incomplete. My hypothesis is that some splits of the functional tests sometimes complete ahead of integration tests, and the coverage is reported too early.
E.g. https://codecov.io/gh/filecoin-project/go-filecoin/pull/3410/changes, https://circleci.com/workflow-run/f43cc8b9-84aa-4dcf-ac45-1e18c484f821
Functional test parallelism was too high: one of the containers ran zero tests.