Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set atomic coverage mode and configure CircleCI to wait for all builds before publishing coverage #3369

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

anorth
Copy link
Member

@anorth anorth commented Sep 9, 2019

I'm not 100% sure this solves all our problems, but we gotta try.

There remains a few lines of non-determinism which is reproducible locally.

Closes #2785

@codecov-io
Copy link

codecov-io commented Sep 9, 2019

Codecov Report

Merging #3369 into master will increase coverage by 6%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #3369     +/-   ##
========================================
+ Coverage      26%     32%     +6%     
========================================
  Files         226     224      -2     
  Lines       14193   14029    -164     
========================================
+ Hits         3750    4577    +827     
+ Misses       9872    8771   -1101     
- Partials      571     681    +110

@anorth anorth changed the title Another attempt at codecov Set atomic coverage mode and configure CircleCI to wait for all builds before publishing coverage Sep 9, 2019
@anorth anorth marked this pull request as ready for review September 10, 2019 01:11
@anorth anorth merged commit 222d7a1 into master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report test coverage metrics in CI builds
4 participants