feat: publish to IPFS on PR #976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds step to pin the rendered website to IPFS, whenever a commit is pushed or a PR is opened or updated. - Replaces hardcoded paths with the $GITHUB_WORKSPACE var. This makes the build work on forked repos, where the repo has to be renamed, and shields us from future issues if actions change their workspace dir. - Updated the github action to pin to IPFS to work with the new style github actions https://github.com/ipfs-shipyard/ipfs-github-action License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
vmx
approved these changes
Jul 13, 2020
|
@hugomrdias pointed out that this needs to build on PRs, but the exiting workflow is only configured for building on change to master, so am fixing that. |
need to pin a preview to ipfs on every commit, not just on master. License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
the docs show you can use any sub semver string to point to an action, but it doesnt work for user repos. License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
|
@hugomrdias it lives! IPFS preview on PR. The
|
|
Nice thank you!! Can we make the github check link the actual http ipfs url ? |
hugomrdias
approved these changes
Jul 14, 2020
|
It already do! |
hugomrdias
added a commit
that referenced
this pull request
Aug 31, 2020
* master: feat: add to IPFS on PR (#976)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$GITHUB_WORKSPACEvar. This makes the build work on forked repos, where the repo has to be renamed, and shields us from future issues if actions change their workspace dir.IPFS ACTION IN ACTION
This will give us a github status entry on each commit that links to a rendered build, published to IPFS and pinned on cluster.ipfs.io
I've added the required
CLUSTER_USER&CLUSTER_PASSWORDsecrets to the repo.Fixes: #581
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io