This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Remove vestiges of CC upgrade by replacement #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
reviewed
Dec 14, 2021
| // Returns an error if the target sector cannot be found, or some other bad state is reached. | ||
| // Returns false if the target sector is faulty, terminated, or unproven | ||
| // Returns true otherwise | ||
| func (st *State) CheckSectorHealthExcludeUnproven(store adt.Store, dlIdx, pIdx uint64, sector abi.SectorNumber) (bool, error) { | ||
| func (st *State) CheckSectorHealthExcludeUnproven(store adt.Store, dlIdx, pIdx uint64, sector abi.SectorNumber, requireProven bool) (bool, error) { |
There was a problem hiding this comment.
Why add this if it's never being called with false?
There was a problem hiding this comment.
So that someone doesn't copy-paste this method in the future when they want a minor change in functionality.
I can remove this flag if @ZenGround0 concurs.
ZenGround0
approved these changes
Dec 20, 2021
| // Returns an error if the target sector cannot be found, or some other bad state is reached. | ||
| // Returns false if the target sector is faulty, terminated, or unproven | ||
| // Returns true otherwise | ||
| func (st *State) CheckSectorHealthExcludeUnproven(store adt.Store, dlIdx, pIdx uint64, sector abi.SectorNumber) (bool, error) { | ||
| func (st *State) CheckSectorHealthExcludeUnproven(store adt.Store, dlIdx, pIdx uint64, sector abi.SectorNumber, requireProven bool) (bool, error) { |
ZenGround0
approved these changes
Dec 20, 2021
Codecov Report
@@ Coverage Diff @@
## master #1542 +/- ##
========================================
+ Coverage 69.3% 69.7% +0.3%
========================================
Files 72 72
Lines 8737 8690 -47
========================================
- Hits 6060 6057 -3
+ Misses 1817 1774 -43
+ Partials 860 859 -1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change, the removed code was unreachable.