This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Scenario tests measuring pre-commit gas cost, by batch size. #1426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a scenario test that measures the gas cost of PreCommitSectorBatch for various batch sizes. When pre-committing 1000 sectors, at the maximum batch size, the per-sector cost is reduced to 15% vs batch size of 1 (so 6.5x improvement). With smaller sector counts the relative improvement of large batches is even better (because the HAMT stays smaller).
Note that this underestimates the improvement to the current mainnet code, because the single-sector case enjoyed some state access optimisations during implementation in terms of the new PreCommitSectorBatch.
The earlier commits in this PR implement some clean-up and I was getting my head around the VM stats. Feel free to ask for reversion of or push a commit reverting anything that doesn't work for you. The TestMeasurePoRepGas output now looks like